kubernetes-sigs/node-feature-discovery-operator

Link not working in Advanced section

vaibhav2107 opened this issue · 15 comments

vaibhav2107 commented

In https://kubernetes-sigs.github.io/node-feature-discovery-operator/v0.2/advanced/nodefeaturediscovery.html
For more information about how to setup the WorkerConfig stanza, see worker config reference, the link is giving 404 Error.

I think there might be some version problem in the redirected link.

vaibhav2107 commented

/good-first-issue
/help

k8s-ci-robot commented

@vaibhav2107:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Evalle commented

/assign

Evalle commented

Hi @vaibhav2107 the link should point to https://kubernetes-sigs.github.io/node-feature-discovery/v0.9/advanced/worker-configuration-reference.html can you point me to the place where I can change that? Thanks!

vaibhav2107 commented

@Evalle
I think you can change that in file nodefeaturediscovery.md placed under the docs section (docs -> advanced).

  • 👍2
Evalle commented

On nodefeaturediscovery.md file the link builds via

https://kubernetes-sigs.github.io/node-feature-discovery/{{site.operand_version}}/advanced/worker-configuration-reference.html)

note {{site.operand_version}}.

I found only operand_version variable in the repository, which has v0.8 value (https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/docs/_config.yml#L56) not v0.7 or v0.2.
Am I missing something? Thanks!

Evalle commented

@vaibhav2107 any feedback on this ^ Thanks!

vaibhav2107 commented

@Evalle, ya I have seen operand_version is showing v0.8. Maybe it has to be changed to the current version.

@marquiz could you guide here.

marquiz commented

Hmm 🤔 The (operator) documentation was backported to v0.2 from master. The page that the link refers to does not exist in operand version v0.7.0. Maybe we should drop the whole sentence (For more information about how to setup the Worker...)

vaibhav2107 commented

@marquiz Thanks for the help.

@Evalle Could you do as per the comment.

  • 👍2
k8s-triage-robot commented

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

vaibhav2107 commented

/remove-lifecycle stale

vaibhav2107 commented

Fixes in #99

vaibhav2107 commented

/close

k8s-ci-robot commented

@vaibhav2107: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.