make test: also test that building the example works
pohly opened this issue · 8 comments
The prow jobs don't check that examples/hostpath-provisioner is in a healthy state.
Either "make test" or "make build" should cover that. I'm leaning to "make test", but that's debatable.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
/remove-lifecycle stale
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
/remove-lifecycle stale
/lifecycle frozen
/help
@jsafrane:
This request has been marked as needing help from a contributor.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
/help
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Thank you for highlighting this issue.
I think there can be two ways to address this issue,
--> Integrate make test: This would run tests to ensure functionality and correctness.
--> Integrate make build: This would ensure the example builds successfully, though it won't verify runtime behavior.
We need to ensure that examples/hostpath-provisioner at least builds. Even that would be a great improvement.
If you can, adding an e2e test that checks the example even works would be awesome, but that requires setting up a Kubernetes cluster for the e2e job.