kubernetes-sigs/windows-operational-readiness

remove linters or fix em

jayunit100 opened this issue · 6 comments

Describe the bug. What is the current and expected behaviour?

looks like on simple PRs we get some verify/lint errors. lets either remove the lints if unneeded or fix them.

Example #81

How to reproduce it (as minimally and precisely as possible)?

make a PR :)
As an example make a PR like the one above and you'll see the lint failures. probably they are referencing pre-exisiting lint issues we've never tackled

/good-first-issue

@jayunit100:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I think this is already fixed.

Yes, this was fixed. Sorry I saw this late. See issue #78 and PR #87

/close

@tzifudzi: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.