kubernetes/examples

guestbook-go not working as is

AntoineToussaint opened this issue · 17 comments

AntoineToussaint commented

There are two issues:

  • Docker build fails:
 => ERROR [stage-0 2/5] RUN go get github.com/codegangsta/negroni            github.com/gorilla/mux            github.com/xyproto/simpleredis                                              4.5s
------
 > [stage-0 2/5] RUN go get github.com/codegangsta/negroni            github.com/gorilla/mux            github.com/xyproto/simpleredis:
4.463 package github.com/xyproto/simpleredis: no Go files in /go/src/github.com/xyproto/simpleredis

Fix: add /v2 to simpleredis version.

  • Docker image referenced in Replica Controller aims replica redis client at deprecated service name redis-slave:
curl localhost:3000/rpush/k/v
PANIC: dial tcp: lookup redis-slave on 10.96.0.10:53: no such host
goroutine 5 [running]:

Fix: Deploy v4 version of registry.k8s.io/guestbook based on current main.go and update Kubernetes manifest.

I would do a PR but I am not sure what the process is to update the Docker image.

dkwgit commented

Also, the Makefile should be fixed. make build builds the image with staging-k8s.gcr.io but the manifest file for guestbook controller points to registry.k8s.io.

lopter commented

I also just ran into that issue, it was confusing.

Martande8055 commented

I also faced the same issue.
I like to work on this issue, Please assign it to me.

pranav-pandey0804 commented

/sig cluster-lifecycle

Martande8055 commented

hey, @pranav-pandey0804, can I work on this?

pranav-pandey0804 commented

@Martande8055 sure, you don't need to ask to work on a issue

pranav-pandey0804 commented

Just comment '/assign' and it will be assigned to you automatically

pranav-pandey0804 commented

@Martande8055 also you need to sign the CLA if you haven't already and make sure to follow community guidelines

Martande8055 commented

/assign

Martande8055 commented

Thank you so much @pranav-pandey0804 for guidance me.

  • 👍1
bansalji02 commented

/assign

k8s-triage-robot commented

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.