Array of empty items is empty
Closed this issue · 4 comments
Looks like
if (json[this.name]) {
should be
if (this.name in json) {
otherwise empty items get concatenated.
Must work out how to push to GitHub...
@zebmason was in hurry may be that I did quick null check, would fix it, or may be you can submit a pull request :) Thanks anyway!
Kushal
Forgot to say thank you for posting the code. Am surprised with myself that I managed to debug my problem as it’s the first time I’ve got the debugger working in a browser.
Haven’t quite managed managed to push to GitHub yet, was wasting time trying to push to a GitLab instance this afternoon.
Cheers
Zeb
From: Kushal Pandya [mailto:notifications@github.com]
Sent: 17 November 2014 05:49
To: kushalpandya/JSONify
Cc: zebmason
Subject: Re: [JSONify] Array of empty items is empty (#1)
@zebmason https://github.com/zebmason was in hurry may be that I did quick null check, would fix it, or may be you can submit a pull request :) Thanks anyway!
—
Reply to this email directly or view it on GitHub #1 (comment) . https://github.com/notifications/beacon/AJVi8YxrVPhhYCDuWGEvKT_SVUKgBdH3ks5nOYPdgaJpZM4C8NEE.gif
I can take a look at this. 🙂
Fixed by #4