laverdet/node-fibers

npm install crashing due to fiber install script

mikr13 opened this issue · 1 comments

mikr13 commented

On Windows, Powershell Terminal:
fibers@4.0.2 install: node build.js || nodejs build.js

At line:1 char:15
node build.js || nodejs build.js
                    ~~
The token '||' is not a valid statement separator in this version.
+ CategoryInfo : ParserError: (:) [], ParentContainsErrorRecordException
+ FullyQualifiedErrorId : InvalidEndOfLine

Why are scripts like these implemented without caring about the compatibility?

laverdet commented

Why are scripts like these implemented without caring about the compatibility?

This line was written in 2011 before nodejs even supported Windows at all. It was added for compatibility with Ubuntu.

Install fibers via cmd.exe and you won't run into problems. This is the same for many other C++ nodejs projects.

  • 👍1