lazd/gulp-handlebars

[Enhancement] gulp-define-module default options

mattma opened this issue · 1 comments

file.defineModuleOptions has a require property, and it pass Handlebars: 'handlebars' as default.

I believe it works in most of use cases, but for Ember project, it is not the case. Because Ember.Handlebars is used in application orchestration instead of plain Handlebars. See my issue and here is the PR.

gulp-define-module simply proxy Handlebars: 'handlebars from gulp-handlebars. Could we do something here instead of user manually remove the value. .omit(opts.require, 'Handlebars');

@lazd I have closed the issue on gulp-define-module. I work with phated on gulp-wrap-amd instead.