leeper/slopegraph

col.lines[i] not working

pbradl42 opened this issue · 4 comments

pbradl42 commented

col.lines is not working correcting in the function 'slopegraph'. It can be fixed easily, by adding 'n' to the cbind command that creates 'todraw' (line155), thus passing the index of the line in question to the apply function on line 157. Then add the line ' i <- rowdata[5]' to the apply function (line 162, e.g.) and the lines will color as expected.

leeper commented

Can you send a Pull Request?
On Mar 2, 2016 8:52 PM, "Peter Bradley" notifications@github.com wrote:

col.lines is not working correcting in the function 'slopegraph'. It can
be fixed easily, by adding 'n' to the cbind command that creates 'todraw'
(line155), thus passing the index of the line in question to the apply
function on line 157. Then add the line ' i <- rowdata[5]' to the apply
function (line 162, e.g.) and the lines will color as expected.

—
Reply to this email directly or view it on GitHub
#8.

pbradl42 commented

Done - thanks, and sorry for my learning curve with the git hub process-- even though I’m an old school UNIX guy, I haven’t been active in dev communities in some 20 years.

Peter Bradley | Director of the Honors Program
Ferris State University
202 South Street, Pickell 142 | Big Rapids, MI 49307
peterbradley@ferris.edu | www.ferris.edu/honors/
@FerrisHonors | @pbradl42
231.591.2216

On Mar 2, 2016, at 6:27 PM, Thomas J. Leeper notifications@github.com wrote:

Can you send a Pull Request?
On Mar 2, 2016 8:52 PM, "Peter Bradley" notifications@github.com wrote:

col.lines is not working correcting in the function 'slopegraph'. It can
be fixed easily, by adding 'n' to the cbind command that creates 'todraw'
(line155), thus passing the index of the line in question to the apply
function on line 157. Then add the line ' i <- rowdata[5]' to the apply
function (line 162, e.g.) and the lines will color as expected.

—
Reply to this email directly or view it on GitHub
#8.

—
Reply to this email directly or view it on GitHub #8 (comment).

leeper commented

Thanks! And no worries.

Closed by #10

pbradl42 commented

No problem!

Peter Bradley | Director of the Honors Program
Ferris State University
202 South Street, Pickell 142 | Big Rapids, MI 49307
peterbradley@ferris.edu | www.ferris.edu/honors/
@FerrisHonors | @pbradl42
231.591.2216

On Mar 3, 2016, at 12:32 PM, Thomas J. Leeper notifications@github.com wrote:

Thanks! And no worries.

Closed by #10 #10
—
Reply to this email directly or view it on GitHub #8 (comment).