leka/LekaOS

✅ (video): Clean JPEG unit tests

YannLocatelli opened this issue · 0 comments

Some tests are commented in CoreJPEG, find out why and improve coverage for these files

  • CoreJPEG
  • CoreJPEGModeDMA
  • (CoreJPEGModePolling)

// TEST_F(CoreJPEGModeDMATest, onDataAvailableCallback)
// {
// auto size = uint32_t {2};
// {
// InSequence seq;
// EXPECT_CALL(filemock, seek).Times(1);
// EXPECT_CALL(filemock, read(Matcher<uint8_t *>(_), _)).WillOnce(Return(42));
// EXPECT_CALL(halmock, HAL_JPEG_ConfigInputBuffer).Times(1);
// }
// corejpegmode.onDataAvailableCallback(&hjpeg, size);
// }
// TEST_F(CoreJPEGModeDMATest, onDataAvailableCallbackSizeEqual)
// {
// auto size = uint32_t {42};
// EXPECT_CALL(filemock, read(Matcher<uint8_t *>(_), _)).WillOnce(Return(42));
// EXPECT_CALL(halmock, HAL_JPEG_Decode).Times(1);
// corejpegmode.decode(&hjpeg, &filemock);
// {
// InSequence seq;
// EXPECT_CALL(filemock, seek).Times(0);
// EXPECT_CALL(filemock, read(Matcher<uint8_t *>(_), _)).WillOnce(Return(42));
// EXPECT_CALL(halmock, HAL_JPEG_ConfigInputBuffer).Times(1);
// }
// corejpegmode.onDataAvailableCallback(&hjpeg, size);
// }
// TEST_F(CoreJPEGModeDMATest, onDataAvailableCallbackCannotReadFile)
// {
// auto size = uint32_t {2};
// {
// InSequence seq;
// EXPECT_CALL(filemock, seek).Times(1);
// EXPECT_CALL(filemock, read(Matcher<uint8_t *>(_), _)).WillOnce(Return(0));
// EXPECT_CALL(halmock, HAL_JPEG_ConfigInputBuffer).Times(0);
// }
// corejpegmode.onDataAvailableCallback(&hjpeg, size);
// }
// TEST_F(CoreJPEGModeDMATest, decodeSuccess)
// {
// EXPECT_CALL(filemock, read(Matcher<uint8_t *>(_), _)).WillOnce(Return(42));
// EXPECT_CALL(halmock, HAL_JPEG_Decode).Times(1);
// auto status = corejpegmode.decode(&hjpeg, &filemock);
// EXPECT_EQ(status, HAL_OK);
// }
// TEST_F(CoreJPEGModeDMATest, decodeFailed)
// {
// EXPECT_CALL(filemock, read(Matcher<uint8_t *>(_), _)).WillOnce(Return(0));
// EXPECT_CALL(halmock, HAL_JPEG_Decode).Times(0);
// auto status = corejpegmode.decode(&hjpeg, &filemock);
// EXPECT_NE(status, HAL_OK);
// }