Merge to ERPNext Core?

Question

Merge to ERPNext Core?

Closed this issue 5 years ago · 9 comments

Seems you are doing interesting work, why not add it to core and make it available out-of-the-box to everyone with the regional module?

https://discuss.erpnext.com/t/automated-bank-reconciliation-in-erpnext/16736/9

Answer 1 · 2018-05-23T12:10:46.000Z

Hi @rmehta,

thanks for your feedback. While there are some parts that might be interesting for the core, the idea is that this is a country localisation module. Most of the features are relevant only in Switzerland (such as tax declarations, HR forms, banking).

Answer 2 · 2018-05-24T03:18:07.000Z

country localizations are not in the core. this will get more users and collaborators as you go ahead. Also localizations will get updated along with major releases incase there are design changes.

https://github.com/frappe/erpnext/tree/develop/erpnext/regional

Answer 3 · 2019-04-12T05:50:22.000Z

While there are some parts that might be interesting for the core, the idea is that this is a country localisation module.

the FullSize view i.e. would probably serve many non-swiss users.

Answer 4 · 2019-04-16T07:10:16.000Z

There is actually a variety of functions used in a broader context, such as the complete bank integration (ISO 20022 with pain and camt are applied across Europe, csv-import now with custom templates can be used worldwide), fullsize and also the upcoming ZUGFeRD integration (Europe)... So I fully agree, it is not a country localisation. And with the release cycles we are bound to keep it separate.

Answer 5 · 2019-11-05T17:28:07.000Z

I read the thread and still do not understand why this is not part of the ERPNext core. The situation looks like a lose lose to me.

ERPNext loses as the features are not part of the core. It's not tested by default. And the libracore repo is maintained by only one user.

Answer 6 · 2019-11-06T14:17:28.000Z

maintained by only one user
This is not true, this repo is maintained by a company, so the same as frappe

looks like a lose lose
independent of in the core or not, this feature is available to all ERPNext users through the app. So the user does have the functionality and ERPNext profits from having this as well. I wonder why the app store is gone.

It's not tested by default
I strongly doubt that the frappe core devs are in a position to test this. AFAIK, neither do they have the connections to banks, reference data nor the ISO standard itself. If this should be tested, it is with a company strongly engaged in banking integration. Why not libracore?
As to testing, I would be more than happy if the core team assures proper testing of the core function (refer to the currency bug).

So the actual win-win is to have a great database Framework maintained by Frappe. And business functionality added as an app, well maintained by a company with competences in this particular field. Who loses?

Lastly, the unpredictable release plans of ERPNext makes it almost impossible to have this on a planned good quality level.

Answer 7 · 2019-11-06T15:06:10.000Z

I think it’s fair. No one is obliged to contribute and people may or may not contribute based on many reasons. Those who want to contribute will find a way, those who don’t, will find a dozen reasons not to. Each path has its own consequences. Free software does not mean we are all universally aligned. Such is life! Sent from phone

…

On 06-Nov-2019, at 7:47 PM, lasalesi ***@***.***> wrote: maintained by only one user This is not true, this repo is maintained by a company, so the same as frappe looks like a lose lose independent of in the core or not, this feature is available to all ERPNext users through the app. So the user does have the functionality and ERPNext profits from having this as well. I wonder why the app store is gone. It's not tested by default I strongly doubt that the frappe core devs are in a position to test this. AFAIK, neither do they have the connections to banks, reference data nor the ISO standard itself. If this should be tested, it is with a company strongly engaged in banking integration. Why not libracore? As to testing, I would be more than happy if the core team assures proper testing of the core function (refer to the currency bug). So the actual win-win is to have a great database Framework maintained by Frappe. And business functionality added as an app, well maintained by a company with competences in this particular field. Who loses? Lastly, the unpredictable release plans of ERPNext makes it almost impossible to have this on a planned good quality level. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Answer 8 · 2019-11-06T15:57:48.000Z

I can live with that too. Problem is. As soon as the libracore features get replicated in core, your repo is in trouble. I assume it will happen. And the more vibrant the community gets, the more challenging this will become.

…

On Wed, Nov 06, 2019 at 16:06:11, Rushabh Mehta < ***@***.*** > wrote: I think it’s fair. No one is obliged to contribute and people may or may not contribute based on many reasons. Those who want to contribute will find a way, those who don’t, will find a dozen reasons not to. Each path has its own consequences. Free software does not mean we are all universally aligned. Such is life! Sent from phone > On 06-Nov-2019, at 7:47 PM, lasalesi < notifications@ github. com ( ***@***.*** ) > wrote: > > maintained by only one user > This is not true, this repo is maintained by a company, so the same as frappe > > looks like a lose lose > independent of in the core or not, this feature is available to all ERPNext users through the app. So the user does have the functionality and ERPNext profits from having this as well. I wonder why the app store is gone. > > It's not tested by default > I strongly doubt that the frappe core devs are in a position to test this. AFAIK, neither do they have the connections to banks, reference data nor the ISO standard itself. If this should be tested, it is with a company strongly engaged in banking integration. Why not libracore? > As to testing, I would be more than happy if the core team assures proper testing of the core function (refer to the currency bug). > > So the actual win-win is to have a great database Framework maintained by Frappe. And business functionality added as an app, well maintained by a company with competences in this particular field. Who loses? > > Lastly, the unpredictable release plans of ERPNext makes it almost impossible to have this on a planned good quality level. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( #17?email_source=notifications&email_token=AAZZDVXZB6TXGAX72EAB5MLQSLMOHA5CNFSM4E7R6F5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDG3DDI#issuecomment-550351245 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAZZDVVJMXGRXAN2CJJV2KDQSLMOHANCNFSM4E7R6F5A ).

Answer 9 · 2019-11-08T13:18:24.000Z

An app is an open source contribution (note that this is even licensed unter AGPL), which as pointed out will optimally cover user/customer needs. Agree with the the concern from mseibert. Issues with the core coming from the merge of some functionality will actually force users who are using this repo (with all features) to switch to a fork from ERPNext.

Closing this topic.