libretro/slang-shaders

'misc/interlacing' should use OriginalSize, not SourceSize

anikom15 opened this issue · 4 comments

anikom15 commented

If misc/interlacing is used after some shader that requires scaling, SourceSize will no longer equal OriginalSize. The shader depends on accurate information on the size of the emulated device's video output to perform its function. I fail to see how SourceSize can make any sense when OriginalSize exists.

If backwards compatibility is absolutely necessary, a parameter should be added to allow for the shader to use OriginalSize.

hizzlekizzle commented

Hmm, I seem to recall doing this at some point and then changing it for some reason, but I can't think of what that reason would be (it's been several years), so yeah, I'm okay with it.

anikom15 commented

FWIW I created a new shader with OriginalSize instead of SourceSize and haven't run into any issues.

  • 👍1
inactive123 commented

Hi, any idea here on how to move forward?

hizzlekizzle commented

Looks like it was already done the next day: 9e9804c and we just never closed the issue. Doing it now.