CRT Guest Advanced NTSC shader settings are displaying incorrectly
zltbugs opened this issue · 9 comments
When attempting to change the connection type within the CRT Guest Advanced NTSC shader settings, the options displayed are less than what is showing in the help.
Within the ntsc-pass1.slang file, the line that lists the Values, Svideo, Composite, RF does not have those options listed in the shader parameters within Retroarch.
Also there are long dashes that are also listed, while other sections are listed as [SECTION NAME].
/shaders/shaders_slang/crt/shaders/guest/advanced/ntsc/ntsc-pass1.slang
#pragma parameter ntsc-row1 "------------------------------------------------" 0.0 0.0 1.0 1.0
pragma parameter quality "Values: Svideo = 0.0 | Composite = 1.0 | RF = 2.0" 0.0 0.0 1.0 1.0
pragma parameter cust_fringing "NTSC Fringing Value" 1.0 0.0 5.0 0.1
pragma parameter cust_artifacting "NTSC Artifacting Value" 1.0 0.0 5.0 0.1
pragma parameter ntsc-row2 "------------------------------------------------" 0.0 0.0 1.0 1.0
less than what is showing in the help
Which 'help' are you referring to here?
Which 'help' are you referring to here?
The scrolling text that displays the options for each setting. Will post a screen capture when I have an opportunity to get back on that machine.
Added a screen shot of the issue.
I think that was just an oversight on guest.r's part. That is, I suspect he change the values without changing the help text during one of the updates.
That looks like a mistake indeed. Unless he removed one of the modes, which I doubt.
I've noticed the pragma parameter quality "Values: Svideo = 0.0 | Composite = 1.0 | RF = 2.0" 0.0 0.0 1.0 1.0 setting has no effect at all.
It worked fine before.
Correct. It seems guest.r completely removed the quality presets. Dunno why.
"Presets" are still intact, but now like both Artifacting and Fringing are to be set at the same time to 0.0 for Svideo, 1.0 for Composite and 2.0 for RF.
Quality parameter line is only informative.
Prior to these changes custom values didn't have any effect unless the preset was set to -1.0, which was a hard nut to crack for less experienced users.