Use Scalacheck for testing pgn parser

Question

Use Scalacheck for testing pgn parser

lenguyenthanh opened this issue 3 years ago · 4 comments

@johnynek recommendation

I recommend using scalacheck to generate your AST, convert that to string, and then make sure parsing it back to the AST gives you exactly the right thing.

Answer 1 · 2022-01-07T19:58:08.000Z

Can someone please assign me to this!

Answer 2 · 2023-07-25T11:20:15.000Z

Do you mind explaining this a little more? Why do we an AST to test PGN parser?

Answer 3 · 2023-07-25T11:51:25.000Z

The idea is we want to generate valid PGN string and parse it using scalacheck. And the way to do it is generate it's AST a.k. San.

We are already using this technique in some places: BitboardTest, ByColorTest.

But I'm not sure what is the best way to generate those PGN, like if we use legalMoves to generate those, it can be slow, if not the generated PGN can be illegal (but still valid). And do we really care if generated PGNs are legal or not.

Answer 4 · 2024-05-01T04:54:46.000Z

close because We have this: https://github.com/lichess-org/scalachess/blob/master/test-kit/src/test/scala/format/pgn/ParserCheck.scala