lichess-org/scalachess

Regression with regard to castling rights of inner rooks

niklasf opened this issue · 3 comments

Example: 4k3/8/8/8/8/8/8/4K1RR w K - 0 1 (white should only be able to castle with the h-rook)

In X-FEN notation, KQkq always refers to the respective outermost rook. ABCDEFGHabcdefgh is needed to refer to inner rook files.

Looks like writeCastles regressed in 563c167.

I'm looking at this now

@niklasf I pushed a fix at #496 for this regression. This issue seems only causes by FenReader: https://github.com/lichess-org/scalachess/pull/496/files#diff-fc9ffb5ee05e8dcc608301f66590aefa7c7fed16569a81ff95f27721b3981c87L38.

FenWriter is another issue we need to address, I guess.

Fixed writing part with #497