lifeart/vsc-ember-syntax

underscore breaks highlight of js identifiers in template tag

Closed this issue · 1 comments

_ is valid in a js identifier and should be recognised as such

const Hello_worRlD123 = <template>hi</template>;
const HelloWorRlD123 = <template>hi</template>;

<template>
  <Hello_worRlD123 />
  <HelloWorRlD123 />
</template>

and vs code highlight of gjs file

image

possibly issue with regex around here

begin: '(<\\/?)(@|this.)?([a-zA-Z0-9-\\$:\\.]+)\\b',

I think I'll add it to the entity.name.type as you suggested in discord, that should keep the colouring as you'd expect.