⚠️ The contents of this repo have been migrated to theliferay/liferay-frontend-projectsmonorepo and more specifically to the to theguidelines/directory. Maintenance will continue there, and this repo will be archived (ie. switched to read-only mode). Depending on whether files have moved in the new repo, you may be able to see the current version of this page at this location.
This is a live (changing) repository containing general and Liferay DXP-specific guidelines for doing Frontend Development at Liferay Inc.
We don't have a formalized procedure for implementation changes, but informally, we expect most changes to evolve like this:
-
Somebody submits a question (eg. an issue) or proposal (eg. could be an issue or PR).
-
Over a period of some days, we arrive at (or draw near to) a consensus.
-
After an interval that gives people adequate time to respond, we conclude the discussion; ultimately someone like @jbalsas will have the ability to make a call about what the conclusion should be (if it's not clear, or if there is some other reason to veto the consensus).
Once a conclusion is reached, the proposal can be marked with the "resolved" label.
-
PR documenting the guideline gets merged.
-
If possible to enforce via automation, we add linting or other enforcement at the appropriate location (for example, via eslint-config-liferay or tooling that is specific to liferay-portal).