IE11 support
Closed this issue · 4 comments
Hi again :)
I think there is a last problem in a build process. And that is IE11 support.
Not even live demo works in IE11.
https://linuswillner.me/react-console-emulator/
I think it's some kind of transpilation thing, the output contains => which IE11 doesn't know about. Can you please have a look? I'm playing arout your babel configs, but so far no luck
I can check if I can make my code IE compatible, but it’s not a priority nor target for me. If there is a hindrance to IE11 support on my end, I won’t go out of my way to wrangle the support in. Will check.
@linuswillner thanks, I think this is just about a webpack config.
I've tried adding
"targets": {
"browsers": ["last 2 versions", "safari >= 7", "IE >= 11"]
},
and it helped with =>, however I get another transpilation problem afterwards.
You’re hitting the crux of the issue with supporting old browsers: Fix one problem, create another. But I’ll take a look regardless.
Feel free to report any progress you get which might help me forwards on this.
I've taken a look at this and come to the following conclusion.
In order to get the code IE11 compatible out of the box, I would have to Webpack the code that is distributed with this module. This would introduce unnecessary additional overhead as code that doesn't belong in the module would get involved. The minified output you're seeing in the screenshot is created by Webpack, which acts as the top-level development tool (Not package level which is where this project is sitting at).
In general this project uses fairly basic DOM concepts that to my knowledge work in IE as well. However, distributing IE-compatible code is not of my concern at this level.
I did make one change to the build process however. Starting with version 1.7.3, the distributed code will be compatible with a much wider range of Node versions thanks to module transpilation being enabled. Otherwise, this is a won't fix-case for my part.