BUG: If finviz doesnt have ratings table ticker_full_info() fails
ranger9692 opened this issue · 7 comments
finvizfinance version checks
-
I have checked that this issue has not already been reported.
-
I have confirmed this bug exists on the master branch of finvizfinance.
Reproducible Example
x = finvizfinance('acon')
x.ticker_full_info()
Issue Description
Traceback (most recent call last):
File "C:\Users\chris\AppData\Local\Temp\ipykernel_20800\477896250.py", line 1, in
x2 = x.ticker_full_info()
File "C:\Users\chris\anaconda3\lib\site-packages\finvizfinance\quote.py", line 377, in ticker_full_info
self.ticker_outer_ratings()
File "C:\Users\chris\anaconda3\lib\site-packages\finvizfinance\quote.py", line 233, in ticker_outer_ratings
rows = fullview_ratings_outer.findAll("td", class_="fullview-ratings-inner")
AttributeError: 'NoneType' object has no attribute 'findAll'
Expected Behavior
I think you should have the results return with the ratings with an empty dataframe or a nonetype
Installed Versions
(base) C:\Users\chris>pip show finvizfinance
Name: finvizfinance
Version: 0.14.4
Summary: Finviz Finance. Information downloader.
Home-page: https://github.com/lit26/finvizfinance
Author: Tianning Li
Author-email: ltianningli@gmail.com
License: The MIT License (MIT)
Location: c:\users\chris\anaconda3\lib\site-packages
Requires: bs4, datetime, lxml, pandas, requests
Required-by:
It seems ACON
has no outer rating. I will fix it.
The issue is fixed in the latest version. Please upgrade your package.
Currently, I am not planning to do that but looking for contributions to this.