llorllale/cactoos-matchers

pom.xml:162-169: This plugin execution was disabled...

0pdd opened this issue · 27 comments

0pdd commented

The puzzle 159-5a01dc84 from #159 has to be resolved:

cactoos-matchers/pom.xml

Lines 162 to 169 in c5404b8

@todo #159:30min This plugin execution was disabled
(phase was set to `package` before) because it prevents
cactoos from actually using cactoos-matchers since the
interfaces provided by cactoos (`Text`, `Func`, `Scalar`, etc)
and those expected by cactoos-matchers do no match!
Let's find a solution to this situation (not shading the
interfaces for example?) and re-enable this plugin. The best
solution should be discussed with ARC in this todo's ticket.

The puzzle was created by Victor Noël on 27-Sep-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

0pdd commented

This puzzle inherited milestone 1.0.0 from issue #159.

@0crat status

0crat commented

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

0crat commented

@0crat in (here)

@victornoel Job #202 is already in scope

@0crat refuse

0crat commented

@0crat refuse (here)

@victornoel The user @fabriciofx/z resigned from #202, please stop working. Reason for job resignation: Order was cancelled

0crat commented

The job #202 assigned to @baudoliver7/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@victornoel Let's please discuss about this plugin and the problem in question

@baudoliver7 yes, this is not an easy problem. Basically the original need was introduced in #159. If you have ideas to solve this problem, either using the shade plugin or something else, we can discuss it here: this is more a design job than a programming job. If we find a good idea, we will add a new todo.

Alternatively, do not forget you can also refuse jobs if you don't want to do them.

@victornoel This task seems very interesting ! I will try to resolve it :)

@victornoel This ticket is assigned to me but doesn't appear in my agenda. Curious :)

@0crat status

@baudoliver7 you can try raising an issue at zerocracy/farm but I would expect you to get ignored there ^^

0crat commented

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

0crat commented

@0crat status (here)

@baudoliver7 This is what I know about this job in C63314D6Z, as in §32:

@baudoliver7 how is it going with this? I was thinking (if that's possible) that the maven shade plugin could shade everything BUT the interfaces. Then it should be ok.

@baudoliver7 it seems to be possible with:

              <relocations>
                <relocation>
                  <pattern>org.cactoos</pattern>
                  <shadedPattern>org.llorllale.cactoos.shaded.org.cactoos</shadedPattern>
                  <excludes>
                    <exclude>org.cactoos.*</exclude>
                  </excludes>
                </relocation>
              </relocations>

@baudoliver7 btw even if it doesn't appear in the agenda, it's really assigned to you and you will get the points :)

@baudoliver7 how is it going with this? I was thinking (if that's possible) that the maven shade plugin could shade everything BUT the interfaces. Then it should be ok.

@victornoel I think it's the solution. I will try this.

@baudoliver7 not sure why 0pdd didn't close it itself, so I do it manually, don't hesitate in the future to ask if you need tickets to be closed when the job is done :)

@victornoel Got it. Thx :)

0crat commented

Job #202 is not in the agenda of @baudoliver7/z, can't set title

0crat commented

Job #202 is not in the agenda of @baudoliver7/z, can't set title

0crat commented

@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat quality good