lodu/TMobile-NL-Unlimited-Bundle-Automated

Can you please make the Minutes and MBs to check a ENV variable for the Docker container?

Closed this issue · 12 comments

roelbroersma commented

Example: The 4G voor Thuis Extra Snel package is abou 100Mbit. When users are downloading it's possible to download about >3000MB within 5 minutes... so the default check for <2000MB which happens every 5 minutes might not be enough...

lodu commented

Sorry for the late reaction, didn't receive a notification. Good idea: I'll get right on it!

lodu commented

Added with merge of PR: #5 ✅

roelbroersma commented
lodu commented

Env is UPDATE_INTERVAL (see README.md).

Your docker image doesn't have a 'latest' branch, so it's impossible to
download on (for example) an Synology NAS.

is there no way to use "main" in stead of "latest"? (I don't use Synology NAS so wouldn't know)

Mattie112 commented

It has been some years since I was running synology but I am 100% sure you could run tags. I often build my own containers (with tags like dev etc) and that was working.

I found this screenshot for example:
image
https://linuxhint.com/run-docker-containers-synology-nas/

Does that help?

roelbroersma commented
roelbroersma commented
Mattie112 commented

I think you should use:

ghcr.io/lodu/tmobile-nl-unlimited-bundle-automated:main

(at least that is listed in the docs)

lodu commented

As @Mattie112 noticed, Its not using the Docker Hub Registry (I'm not even sure how you ended up there, please tell me if its linked somewhere in this repo) but Github's owns container registry (ghcr.io).
This is due to me using a default template build/publish action (see here, which I'll look into in the future :)).

So try using ghcr.io/lodu/tmobile-nl-unlimited-bundle-automated as the image/container and main as the tag.

roelbroersma commented
roelbroersma commented
lodu commented

So I removed the container from the Docker Hub Registry, so I am closing this issue.