[capture] Move scope helper functions from cycle-converter to scope?

Question

[capture] Move scope helper functions from cycle-converter to scope?

johannheyszl opened this issue a year ago · 2 comments

IMO the two helper functions in cycle_converter.py should also go into scope.py because: they get scope cfg as input, hence, are specific to scope.

We should also rename to them to be consistent with determine_sampling_rate in scope.py. Maybe even group them under a function check_and_convert_cycle_based_cfg.

Would need some refactor in all already existing capture scripts.

Answer 1 · 2023-12-05T16:00:52.000Z

I think I am getting confused now. I thought we didn't want to put these helper functions into the scope code on purpose to keep the scope code simple and allow someone to setup the scopes without using these functions, i.e., by defining the number of samples and offset in samples directly.

I don't have a strong opinion about the naming.

Maybe we should best discuss this in person on THU?

Answer 2 · 2023-12-05T16:06:19.000Z

Yep, the scope 'api' could remain w/o cycles. I just think the three functions could be in the same file and since one is already in scope.py, we might as well put all of them there? They are all very scope specific too. But I am also fine either way ;)