Splitting the CL into parts with suggested approach
Closed this issue · 3 comments
ltilve commented
From https://codereview.chromium.org/1152613003/#msg15
I think we should split it up into (at least) 3. The first one should include
no "real" UI code - that is, it shouldn't have anything touched in ui/views or
ui/cocoa, and you can probably leave out a little of the stuff in, e.g.,
ui/browser. The second should add the views implementation, and the third
should add the cocoa implementation.
ltilve commented
We have been splitting into a smaller set of buildable parts to be grouped into a reasonable patchgroup here https://github.com/ltilve/chromium/commits/igalia-sidebar-CL-splitted
ltilve commented
The initial issue https://codereview.chromium.org/1152613003 has been split for review as suggested into: