Have the Sidebar instead of SidebarManager internal state functions
Closed this issue · 1 comments
ltilve commented
By https://codereview.chromium.org/1152613003/#msg15
https://codereview.chromium.org/1152613003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/sidebar_manager.cc:191: void
SidebarManager::NavigateSidebar(content::WebContents* tab,
Certain methods here (like this one) seem to belong purely on the Sidebar
itself, rather than in the manager. I think the Manager should be responsible
for managing which sidebar is showing (if any), but not responsible for the
internal state of that sidebar (like url).
ltilve commented
The NavigateSidebar code has been refactored out, together with other modifications at the igalia-sidebar-CL-splitted branch and pushed to https://codereview.chromium.org/1152613003/