ltilve/chromium

Fix comments on overflown issues and is_showing_sidebar() changes

Closed this issue · 4 comments

ltilve commented

The following commits fix the initial comments wrt the tests and overflow behaviour f2949bf 0f40076

ryumiel commented

Change about refactoring is uploaded at 605ddfebb24719dbcaa13afe4dcf536a33c4e994
(including is_showing_sidebar)

ryumiel commented

As mentioned in below commit, is_showing_sidebar_ was reverted.
e97b374c3de386d45d57e279faf7870fce8a75f6

Now we are ready to send a CL

ltilve commented

All the comments have been handled and pushed https://codereview.chromium.org/1168383002/#msg14