ltilve/chromium

Use extension's toolbar button depressed for attribution

ltilve opened this issue · 4 comments

As only one sidebar can be shown at once, it's enough for making explicit the extension responsible for it.

Keeping the toolbar button depressed can be done by

view_delegate_->OnPopupShown(grant_tab_permissions);

However, it might be necessary to do some refactoring to be able to receive the notification when the sidebar is closed/hidden to release the depressed state.

The following commits refer to this bug: 9aacd19 and 1e30da2

The commits fffaada and 4dc1293 solve problems happening with "multiple windows / multiple tabs" and "one window / multiple tabs" respectively.

Ported the patches to browserAction branch a5a7f1e ae96756