Query params inside last uri param
hombrew opened this issue · 2 comments
hombrew commented
Hello!
Currently, this lib does not support query params.
What I mean is, suppose you have this route
DeepLinking.addScheme('domain://');
DeepLinking.addRoute('/queryparams/:id', ({id}) => console.log('id: ', id))when evaluating the uri, id gets query params concatenated:
DeepLinking.evaluateUrl('domain://queryparams/1234?q=query&p=param');
// console.log => id: 1234?q=query&p=paramis there any way to get around this?
my intentions isn't to get the query params, but for them to not get concatenated to the last uri param.
probably in a next version, it would be nice for the addRoute callback to receive:
{ path, scheme, match, params, query }
I can send a PR with what I just wrote, but it would be a breaking change.
majiyd commented
Hey, I'm currently experiencing this issue. Did you create a fork?
harshal311989 commented