lutteropp/NetRAX

Bug with Arc Removal Move

Closed this issue · 2 comments

I discovered that ArcRemoval moves destroy the property that clv indices are consecutive... I tried fixing this by remapping network clv indices, but somehow this leads to problems with incremental likelihood computation.

It appears to work fine when I disable incremental likelihood computation, which makes me suspect it has something to do with the pmatrices. The pmatrix entries do only depend on the branch length and the likelihood model parameters, right?

Thanks! I found the problem and fixed it in 947f057