Build error: implicit declaration of function 'MODULE_IMPORT_NS'
Closed this issue · 1 comments
biopsin commented
Heya, can this be ignored?
relates to commit a9164b3
DKMS make.log for 8852au-20230824 for kernel 4.19.292_1 (x86_64)
Mon Aug 28 08:08:36 AM CEST 2023
#rm -f .symvers.8852au
make ARCH=x86_64 CROSS_COMPILE= -C /usr/lib/modules/4.19.292_1/build M=/var/lib/dkms/8852au/20230824/build modules
CC [M] /var/lib/dkms/8852au/20230824/build/os_dep/osdep_service.o
CC [M] /var/lib/dkms/8852au/20230824/build/os_dep/osdep_service_linux.o
CC [M] /var/lib/dkms/8852au/20230824/build/os_dep/linux/rtw_cfg.o
CC [M] /var/lib/dkms/8852au/20230824/build/os_dep/linux/os_intfs.o
/var/lib/dkms/8852au/20230824/build/os_dep/osdep_service_linux.c: In function 'openFile':
/var/lib/dkms/8852au/20230824/build/os_dep/osdep_service_linux.c:392:9: error: implicit declaration of function 'MODULE_IMPORT_NS' [-Werror=implicit-function-declaration]
392 | MODULE_IMPORT_NS(VFS_internal_I_am_really_a_filesystem_and_am_NOT_a_driver);
| ^~~~~~~~~~~~~~~~
/var/lib/dkms/8852au/20230824/build/os_dep/osdep_service_linux.c:392:26: error: 'VFS_internal_I_am_really_a_filesystem_and_am_NOT_a_driver' undeclared (first use in this function)
392 | MODULE_IMPORT_NS(VFS_internal_I_am_really_a_filesystem_and_am_NOT_a_driver);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/8852au/20230824/build/os_dep/osdep_service_linux.c:392:26: note: each undeclared identifier is reported only once for each function it appears in
CC [M] /var/lib/dkms/8852au/20230824/build/os_dep/linux/ioctl_linux.o
CC [M] /var/lib/dkms/8852au/20230824/build/os_dep/linux/xmit_linux.o
/var/lib/dkms/8852au/20230824/build/os_dep/osdep_service_linux.c: In function 'isFileReadable':
/var/lib/dkms/8852au/20230824/build/os_dep/osdep_service_linux.c:508:26: error: 'VFS_internal_I_am_really_a_filesystem_and_am_NOT_a_driver' undeclared (first use in this function)
508 | MODULE_IMPORT_NS(VFS_internal_I_am_really_a_filesystem_and_am_NOT_a_driver);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:303: /var/lib/dkms/8852au/20230824/build/os_dep/osdep_service_linux.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:1562: _module_/var/lib/dkms/8852au/20230824/build] Error 2
make: *** [Makefile:651: modules] Error 2
lwfinger commented
No, it cannot be ignored. I pushed a change that only uses that macro when it is defined. Do a 'git pull' and your code should build again.