Build on openSUSE kernel:stable
Opened this issue · 7 comments
Maybe a wrong kernel-Version in your last commit, should it not be:
`diff -rNu rtl8852au/os_dep/linux/ioctl_cfg80211.c rtl8852aun/os_dep/linux/ioctl_cfg80211.c
--- rtl8852au/os_dep/linux/ioctl_cfg80211.c 2024-04-02 18:09:10.053185383 +0200
+++ rtl8852aun/os_dep/linux/ioctl_cfg80211.c 2024-04-02 18:53:24.749996657 +0200
@@ -488,7 +488,7 @@
if (!rtw_cfg80211_allow_ch_switch_notify(adapter))
goto exit;
-#if (LINUX_VERSION_CODE >= KERNEL_VERSION(5, 19, 2))
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 9, 0)
cfg80211_ch_switch_notify(adapter->pnetdev, &chdef, 0);
#else
#if (LINUX_VERSION_CODE >= KERNEL_VERSION(5, 19, 2))
`
Otherwise I get an error in building for kernel:stable and Tumbleweed:
`[ 60s] /home/abuild/rpmbuild/BUILD/rtl8852au-1.15.0.1~16g912d3ca/obj/default/os_dep/linux/ioctl_cfg80211.c: In function ‘rtw_cfg80211_ch_switch_notify’:
[ 60s] /home/abuild/rpmbuild/BUILD/rtl8852au-1.15.0.1~16g912d3ca/obj/default/os_dep/linux/ioctl_cfg80211.c:492:9: error: too few arguments to function ‘cfg80211_ch_switch_notify’
[ 60s] 492 | cfg80211_ch_switch_notify(adapter->pnetdev, &chdef, 0);
[ 60s] | ^~~~~~~~~~~~~~~~~~~~~~~~~`
For example:
https://build.opensuse.org/package/live_build_log/home:Sauerland/rtl8852au/Kernel_stable/x86_64
Thanks Stephan
I'm getting the same error on Pop!OS 22.04 with kernel 6.8. Thanks for the quick fix 😃
I just push the fix to the repo. Sorry for the error.
Please undo, I mean line 491 the first
if (LINUX_VERSION_CODE >= KERNEL_VERSION(5, 19, 2))
See my patch above.
I reverted the previous change. I hope I got it right this time.
Please excuse me, but I do not work with git, so I can not add something to this Repo.........
Now it builds fine.
But I have an question:
I get many warnings about
[-Wmissing-prototypes]
I can patch the sources so that these warnings are not shown anymore, but are these warnings important?
Many thanks from Stephan
Those missing prototype warnings mostly come from routines that are not mentioned in any header. For the most part, they are static and adding that annotation will clear the warning. They are not important. I have worked on various sources to get rid of them, but it is probably not worth the effort.
In rtl8852bu I have patched the makefile:
EXTRA_CFLAGS += -Wno-missing-prototypes
But thanks for your answer, I will do nothing in rtl8852au.