28.0.50: (wrong-type-argument stringp nil) when trying to set github.user

[sin-ack]

Encountered this while trying to set my GitHub username via Forge. The prompt here:

ghub/ghub.el

Line 819 in ea24efe

(and (eq (read-char-choice

returns nil if the user chooses to save github.user locally (which I did), and call-process doesn't like that. I'm not sure whether a recent change in Emacs caused this though.

Backtrace

  call-process("git" nil nil nil "config" nil "github.user" "sin-ack")
  #f(compiled-function (host &optional forge) #<bytecode -0x41f48bed88cc791>)("api.github.com" nil)
  apply(#f(compiled-function (host &optional forge) #<bytecode -0x41f48bed88cc791>) "api.github.com" nil)
  ghub--username("api.github.com" nil)
  ghub-request("POST" "/graphql" nil :payload "{\"query\":\"query ($owner:String!, $name:String!) {\\..." :headers nil :silent nil :username nil :auth forge :host "api.github.com" :callback nil :errorback nil :extra nil :value nil)
  ghub-graphql("query ($owner:String!, $name:String!) {\n          ..." ((owner . "SerenityOS") (name . "Serenity")) :username nil :auth forge :host "api.github.com")
  ghub--repository-id("SerenityOS" "Serenity" :username nil :auth forge :host "api.github.com")
  ghub-repository-id("SerenityOS" "Serenity" :host "api.github.com" :auth forge :forge github)

[tarsius]

Thanks for the report.