Refactoring / Cleaning Up A Controller

Hey there! We're thoughtbot, a design and development consultancy that brings your digital product ideas to life. We also love to share what we learn.

This coding exercise comes from Upcase, the online learning platform we run. It's part of the Refactoring course and is just one small sample of all the great material available on Upcase, so be sure to visit and check out the rest.

Exercise Intro

In this exercise, you'll be cleaning up controller called ExpensesController. This controller has a number of responsibilities:

List out existing expenses for a user

Filter expenses by amount and approval status
Create a new expense
Email an admin after expenses are created
Change name or amount unapproved expenses
Mark expenses as deleted

That's quite a bit! Time to slim things down.

Instructions

To start, you'll want to clone and run the setup script for the repo

git clone git@github.com:thoughtbot-upcase-exercises/cleaning-up-a-controller.git
cd cleaning-up-a-controller
bin/setup

Before you get started, make sure you run ./bin/setup to install gems and set up your database.

You're going to want to do a few things to the existing controller code:

All public methods should be as RESTful as possible

Make sure the only logic that lives in your controller is related to handling your requests and responses
Apply other techniques from previous exercises and tutorials to clean up this controller as much as possible

Make sure to write tests for any new classes you create during this exercise.

Also, make sure all tests pass before submitting by running rake.

Featured Solution

Check out the featured solution branch to see the approach we recommend for this exercise.

Forum Discussion

If you find yourself stuck, be sure to check out the associated Upcase Forum discussion for this exercise to see what other folks have said.

Next Steps

When you've finished the exercise, head on back to the Refactoring course to find the next exercise, or explore any of the other great content on Upcase.

License

Credits

This exercise is maintained and funded by thoughtbot, inc.

The names and logos for Upcase and thoughtbot are registered trademarks of thoughtbot, inc.

maloneyl/upcase-refactoring-cleaning-up-a-controller