Use scalfmm submodule instead of contrib

Question

Use scalfmm submodule instead of contrib

Closed this issue 2 years ago · 5 comments

GiudGiud commented 2 years ago

This will let us:

use the test harness current options to turn on/off a scalfmm-based test
keep up to date with scalfmm

Do we want to run the scalfmm tests:

on PRs to Ferret
OR
on any MOOSE PR as part of the External Apps recipe Ferret testing

Answer 1 · 2022-08-02T14:39:36.000Z

@GiudGiud any updates here? By the way I think I mentioned in a PR comment thread, the latter option is better - just test MOOSE PRs as part of the external apps recipe. We are not developing so much with ScalFMM lately (although this might change in the future).

Answer 2 · 2022-08-02T14:43:10.000Z

I think we need a merge to master for us.
For you, we need to re-enable Ferret testing on ferret PRs

Answer 3 · 2022-08-02T14:43:48.000Z

Hmm, I think I merged these changes already?

Answer 4 · 2022-08-02T14:46:36.000Z

#215 was merged to devel ?

Answer 5 · 2022-08-02T14:46:46.000Z

then I dont see a follow up PR to master