Missing observations for inital shots (bootstrap_reconstruction)
kielnino opened this issue · 3 comments
When using the incremental reconstruction the reconstruction is seeded with a first inital camera-pair (bootstrap_reconstruction) and afterwards grown by adding single images (grow_reconstruction). I noticed that in the grow-phase the images are resected and on success the shots are added, triangulated and the observations added to the tracks_manager.
This last step (add_observation_to_reconstruction) however is never called on the first two shots which are used to initialize the reconstruction. Now I'm wondering if this is intended?
If this is a mistake, I'm happy to submit a PR.
@fabianschenk Hej Fabian, any idea, who can answer my question resp. decide if a PR is desired?
Hi @kielnino ,
I don't know if this is a bug or intended. Have you tried adding the observations and did you see any difference in quality?
Shouldn't this just be a 2-3 line PR, so quite easy to test?
Just to mention it again: Our priorities have changed and we're not actively developing OpenSfM anymore, so you'll likely not get much feedback from anybody else. If you set up a PR, I can add it but that's about it.
Best Fabian
I've tested the supposed change and didn't noticed any differences. So I'm closing the issue.