Support LexikJWTAuthenticationBundle 3.x
wouter-toppy opened this issue · 5 comments
Support the new upcoming version of LexikJWTAuthenticationBundle 3.0
this has breaking changes, dropping support on PHP <7.1 and Symfony <5.3
See:
Dont think there will be a big issue, because you already require a bigger version of php. and no support for symfony 5.3
only 4.4, but that one is going to be EOL in the coming quarter.
but symfony 4.4 with lexik 2.x will still work.
only if you want to use symfony 5.4 or 6.x you need to use lexik 3.0. but composer handles those requirements.
on the lexik side, there aren't much changes.
we can always require lexik 3.0 in the feature, but than we must drop symfony 4.4 support in this package. buts not a issue for the moment
Unless something changes in the APIs that this bundle uses, there isn't a need to directly require the new major and drop the older bundle and Symfony versions on its own. The only direct uses of the Lexik bundle here are the listener to the lexik_jwt_authentication.on_authentication_success event and using the lexik_jwt_authentication.handler.authentication_(success|failure) services. So unless something major changes with those (which, if someone were to work on lexik/LexikJWTAuthenticationBundle#707 as that does have B/C implications), for this bundle it's really a matter of allowing the new major and tagging the release.
That said, I've got a WIP branch floating around for a 2.0 release of this bundle which predominantly cleans out the deprecations, bumps to requiring PHP 8.1 to match up with Symfony 6.1's requirement (and that's already used by roughly 70% of the folks using this bundle), tightens the dependency range, and drops Symfony 4.4 support. So maybe now'd be a good time to look at that and get everything lined up so when the Lexik bundle's 3.0 release ships this one isn't too far behind.
@mbabker to be clear. your bundle doesn't have to get an new major release.
only lexik is going to get one, which drop older symfony support. you just need to require the new 3.0 release (along side with 2.0) in your bundle, and everything works fine for all version.
still not sure if @chalasr wants to merge my changes in a 3.x release, or in the next 2.17 or something, if its going to merge in 2.17 there is no issue at all in this bundle.
I think preserving the Symfony 4.4 compat for LexikJWTAuthenticationBundle 2.x is nice, so I tend to think we should merge your PR on 3.x @wouter-toppy
@chalasr than we have the same thought on it. and should this bundle require 3.x aswell