mattbrictson/airbrussh

Make rake a gem dependency

pblesi opened this issue · 3 comments

Airbrussh depends on Rake, but Rake is not a gem dependency, only a development dependency:

spec.add_development_dependency "rake", "~> 12.0"

::Rake::Task.class_exec do

Rake should be added as a dependency of airbrussh. Someone ran into this issue in a downstream project: braintree/runbook#9

Thanks for the report!

It seems that we only need rake if the airbrussh config monkey_patch_rake is set to true. By default it is false. It is only set to true when operating under capistrano, and capistrano already has rake as an explicit dependency.

So I think airbrussh should operate fine without rake as a runtime dependency, if we are more careful about doing require "rake" only when monkey_patch_rake is set to true.

I'll put up a PR.

🎆 Thanks!