Text gets invisible while running mocha
umayr opened this issue · 11 comments
My iTerm version is 2.1.4.
I fixed this in a gist of mine (I should launch a PRQ for this :) ) -> https://gist.github.com/kevin-smets/8568070#file-solarized-dark-fixed-itermcolors
The link fixes this: by default, the Ansi 8 Color is not readable on the set background for Solarized dark. This value has been replaced by the one from the Solarized high contrast theme.
| should launch a PRQ for this
👍Please do!
Done :)
Before:
After:
@kevin-smets Awesome. But shouldn't it be any base colour rather than blue? Maybe #586e75 or #657b83?
@umayr good point, but that way it does not look like a highlight at all? It looks just like regular output.
(This is #657b83)
Just thought high contrast would be the nicest / closest match. Though the rest of the colors are indeed more grey like in Solarized Dark. But in the high contrast version, the highlight versions match the base colors more closely...
@mbadolato what do you think?
Went with Base01, the darkest content color:
Also adjusted the PRQ to this.
Either works for me; no particular preference. I may be one of the few people that doesn't use Solarized Dark 😉
That looks really awesome. Thank you, @kevin-smets.
No problem, now I can simplify my gist :D 👯
I'm still facing this issue, what's the solution here?
The issue was reverted (see #62). So other than changing the color manually yourself, or using a tweaked theme (or different altogether), this issue is likely to stay, if you're using something that has output in the affected color. AFAIK, the Solarized theme in here matches the official standard, so it's not something with the theme itself, but rather with the output of the program