melvincwng/capstone-assignment-class-1-team-1

Personal Data when uploading databaseConfig.js

Closed this issue · 1 comments

vincentkua commented

@melvincwng
Please advise if we can prevent the sensitive personal data (Password) from accidentally upload.

var mysql = require("mysql");
var dbconnect = {
getConnection: function () {
var conn = mysql.createConnection({
host: "localhost",
user: "root", // Change to your specific MySQL workbench username for it to work
password: "XYZ123", // Change to your specific MYSQL workbench password for it to work
database: "bdd_assignment",
});
return conn;
},
};
module.exports = dbconnect;

melvincwng commented

@vincentkua, usually secrets are encrypted. However, this is beyond the scope of this capstone project.

This is a valid issue, and am glad that you've noticed. You can explore other libraries or packages that can provide encryption/decryption functionalities to see if they work. But since we are running on a extremely tight deadline, this issue will be have to de-prioritized.

I will be closing this issue as discussed with you on WhatsApp. Feel free to explore beyond the syllabus after the capstone project!

Good job @vincentkua 👍🏻