Unnecessary class "form-horizontal" in the slider
Closed this issue · 3 comments
deronnie commented
in this file "boolean-slider/src/components/Label.ts" is the class 'form-horizontal' hard coded in the slider element.
This class comes with the form where you will use the slider, so it should not be in this element.
Also, this tends to break the element on vertical showing forms as seen on this image:
This easy and quick fix makes the slider even more usefull ;)
edwinmp commented
Hi @deronnie, thanks for raising this. It has been addressed in the next release. Will let u know when it's been published.
deronnie commented
Yes! thanks!
Van: Edwin P. Magezi [mailto:notifications@github.com]
Verzonden: woensdag 24 januari 2018 13:35
Aan: mendixlabs/boolean-slider <boolean-slider@noreply.github.com>
CC: Doorn, Ronnie van <ronnie.van.doorn@enexis.nl>; Mention <mention@noreply.github.com>
Onderwerp: Re: [mendixlabs/boolean-slider] Unnecessary class "form-horizontal" in the slider (#14)
Hi @deronnie<https://github.com/deronnie>, thanks for raising this. It has been addressed in the next release. Will let u know when it's been published.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#14 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ARTR1w8ZZ6RlHrGa0xXvDy1IDSLjA_3cks5tNyOQgaJpZM4RrLtJ>.
Andries-Smit commented
Dear Ronnie
The requested change is applied and release https://appstore.home.mendix.com/link/app/50324/ version 2.0.2
Please let u know if this solves your problem.
Cheers, Andries