mercari/tfnotify

Does not delete first comment on commit revision in github.

fnaoto opened this issue 5 years ago · 1 comments

fnaoto commented 5 years ago

WHAT

Want to support delete comment on commit as well as github issue.

WHY

On the first commit, that comment does not deleted when PR is opened and commit is pushed.
I think this line is only support to delete comment from issues.
- tfnotify/notifier/github/comment.go
  
  Line 78 in 8d46acb
  
  comments, _ := g.client.Comment.List(g.client.Config.PR.Number)

fnaoto commented 5 years ago

This Issue depends on github api.
Can use this: https://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request
But this is public beta api, so the issue close.