Compiler pass incompatibility with upcoming pegjs 0.11
lindner opened this issue · 4 comments
lindner commented
It appears that pegjs changed their API for compiler passes
// pegjs 0.10 api pass(ast, options)
// pegjs 0.11+ api pass(ast, config, options);
It should be fairly easy to special case that.
pjmolina commented
Thanks. Good point.
However v. 0.11 is not yet published as stable in npmjs, but as dev
release.
Therefore I will stick to 0.10 as stable version and incorporate your change when 0.11 is marked as stable.
Works for you @lindner in the meantime?
lindner commented
This is fine; but the change is compatible with 0.10 and 0.11 so it is safe
to add now.
I sure wish they would release a new pegjs, there's a lot of useful work
that hasn't been released yet..
…On Mon, May 27, 2019 at 4:42 AM Pedro J. Molina ***@***.***> wrote:
Thanks. Good point.
However v. 0.11 is not yet published as stable in npmjs, but as dev
release.
Therefore I will stick to 0.10 as stable version and incorporate your
change when 0.11 is marked as stable.
Works for you @lindner <https://github.com/lindner> in the meantime?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34?email_source=notifications&email_token=AAAXTS54V2VJQD7CVTB645TPXPCI7A5CNFSM4HNQVB72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWJSTJQ#issuecomment-496183718>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAXTS7KMKXBNM7OMO55FR3PXPCI7ANCNFSM4HNQVB7Q>
.
pjmolina commented
Oh I see. Then, agreed to merge it right now.
pjmolina commented
Merged and published as version: ts-pegjs@0.2.4