Publish release artifacts with manifests
lentzi90 opened this issue · 16 comments
What steps did you take and what happened:
As seen in metal3-io/metal3-docs#414 we are not setting the image tag in the manifests. This is fine for the main branch, but it is not ideal for release branches and tags.
I think we should set the image tag always on release branches to the same as the release branch and for tags to the exact tag.
Otherwise a user trying to apply manifests from release-0.6 for example, will end up with the latest container image from main.
Alternatively, instead of setting the image tag directly in the manifests we keep in the repo, we could consider publishing release artifacts where the correct image tag is used. This is done in CAPI but I think this is hard to do in practice for BMO since users will need to adapt the manifests to their environment.
What did you expect to happen:
When using manifests from a specific branch or tag, the corresponding container image should be used.
We should probably include this in the release process.
/kind bug
/triage accepted
/help
@Rozzii:
This request has been marked as needing help from a contributor.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
/help
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
hey I would like to contribute to it if someone has not picked it up yet
Go for it!
/assign @7h3-3mp7y-m4n
/assign
@lentzi90 : should we do it for previous release branches as well , or current one only?
Also if we hardcode the value lets say for next release, we take it as v0.6.1, would this need to be updated in every release.
Isnt there a way to automate this one ?
@babugeet are you working together with @7h3-3mp7y-m4n ? If not, please let @7h3-3mp7y-m4n get a chance to work on this first.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle stale
/remove-lifecycle stale