meteorhacks/picker

Picker is not woking with Fast-Render

woogenius opened this issue · 10 comments

Hi, @arunoda.

I currently update meteor version to 1.1.0.3. And I found Picker is not working with Fast-Render.
When I use server side route, Fast-Render can't inject data. But when I turn off server side route, Fast-render is working properly. Maybe it's a next() function bug?

Thanks in advance.

Could you isolate this and send me a sample app?

On Thu, Aug 27, 2015 at 8:03 AM WooJin notifications@github.com wrote:

Hi, Arunoda.

I currently update meteor version to 1.1.0.3. And I found Picker is not
working with Fast-Render.
When I use server side route, Fast-Render can't inject data. But when I
turn off server side route, Fast-render is working properly. Maybe it's a
next() function bug?

Thanks in advance.


Reply to this email directly or view it on GitHub
#22.

Yeah I'll Thanks.

On Thu, Aug 27, 2015 at 12:10 PM, Arunoda Susiripala <
notifications@github.com> wrote:

Could you isolate this and send me a sample app?

On Thu, Aug 27, 2015 at 8:03 AM WooJin notifications@github.com wrote:

Hi, Arunoda.

I currently update meteor version to 1.1.0.3. And I found Picker is not
working with Fast-Render.
When I use server side route, Fast-Render can't inject data. But when I
turn off server side route, Fast-render is working properly. Maybe it's a
next() function bug?

Thanks in advance.


Reply to this email directly or view it on GitHub
#22.


Reply to this email directly or view it on GitHub
#22 (comment).

@arunoda
Sample App: http://fast-render-picker-example.meteor.com/
Code: https://github.com/WooGenius/fast-render-with-picker-example

When I use server side route and fast-render at the same time, Fast render data is not injected.
You can check on http://fast-render-picker-example.meteor.com/with-fast-render-and-server-side-route
If fast render works, You should not see 'Loading...' text and there should be an injected data on head tag.

I just ran into this issue too.

Let's see. I will fix this today.
On 2015 අගෝ 29, සෙන at පෙ.ව. 11.39 Rahul notifications@github.com wrote:

I just ran into this issue too.


Reply to this email directly or view it on GitHub
#22 (comment).

Was this issue resolved?

@woogenius Here's the situation. FastRender also use Picker behind the scene.
In this case, both FR and your code register a route.

So, your code wins but not FR's route. We don't pass multiple route handlers for a single route.
May be we should try to throw an error.

So, I suggest you to use a middleware instead to do your stuff. See below:

  Picker.middleware(function (request, response, next) {
    if(request.url === "/with-fast-render-and-server-side-route") {
      console.log("Pass through server side route");
    }

    next();
  });

@Primigenus I was about to look at this issue. But this was lost in my mailbox. Thanks @Primigenus and @newswim for reminding this.

BTW: I'm gonna close this issue since this is not a bug, but a question.

@arunoda Thanks! I'll try

Sent from my iPhone

On Sep 25, 2015, at 9:46 PM, Arunoda Susiripala notifications@github.com wrote:

@Primigenus I was about to look at this issue. But this was lost in my mailbox. Thanks @Primigenus and @newswim for reminding this.

BTW: I'm gonna close this issue since this is not a bug, but a question.


Reply to this email directly or view it on GitHub.