func FilesFromDisk filenames arg, if path seperator is not system defined, pathInArchieve may be wrong path

Question

func FilesFromDisk filenames arg, if path seperator is not system defined, pathInArchieve may be wrong path

mind-owner opened this issue a year ago · 7 comments

mind-owner commented a year ago

What version of the package or command are you using?

What are you trying to do?

What steps did you take?

What did you expect to happen, and what actually happened instead?

How do you think this should be fixed?

Please link to any related issues, pull requests, and/or discussion

Bonus: What do you use archiver for, and do you find it useful?

Answer 1 · 2023-08-21T08:07:39.000Z

	map[string]string{
		"disk/folder2":             "CF", // contents added recursively
	})

I want disk/folder2/a.txt to be CF/a.txt，but it's CF/disk/folder2/a.txt, in windows

Answer 2 · 2023-08-21T13:21:43.000Z

Thanks, I'll look into this (but I don't use Windows so I'll ask for your help to verify)

Answer 3 · 2023-08-21T13:37:33.000Z

Ok so I just looked at the tests and this is expected. What happens if you specify disk/folder2/ or CF/ instead? (It's been a long time since I've looked at this code, but I'm pretty sure what you're asking for can be done. I just don't remember how, and probably need to improve the docs.)

Answer 4 · 2023-08-21T15:40:54.000Z

in windows the seperator is \，if l use / in filenames arg，it will not work as I want, maybe you can turn \ to / in arg to return the right path

…

---Original--- From: "Matt ***@***.***> Date: Mon, Aug 21, 2023 21:37 PM To: ***@***.***>; Cc: ***@***.******@***.***>; Subject: Re: [mholt/archiver] func FilesFromDisk filenames arg, if pathseperator is not system defined, pathInArchieve may be wrong path (Issue #382) Ok so I just looked at the tests and this is expected. What happens if you specify CF/ instead? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

Answer 5 · 2023-08-21T16:07:26.000Z

@mind-owner You mean disk/folder2 -> disk\folder2?

If that works for you on Windows then I suggest using that 🤷‍♂️ -- nothing needs to be fixed. (We're already using filepath.* function which do account for path separators.)

Answer 6 · 2023-08-21T16:53:09.000Z

yes, you are right. I can use \ in windows to return the right path. and usually people would only use / as the path seperator in any system(linux,windows etc), l hope the func FilesFromDisk can support this feature, then l don't need to mention / or \, thanks.

…

---Original--- From: "Matt ***@***.***> Date: Tue, Aug 22, 2023 00:07 AM To: ***@***.***>; Cc: ***@***.******@***.***>; Subject: Re: [mholt/archiver] func FilesFromDisk filenames arg, if pathseperator is not system defined, pathInArchieve may be wrong path (Issue #382) @mind-owner You mean disk/folder2 -> disk\folder2? If that works for you on Windows then I suggest using that 🤷‍♂️ -- nothing needs to be fixed. (We're already using filepath.* function which do account for path separators.) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

Answer 7 · 2023-09-07T23:05:04.000Z

@mind-owner If you call filepath.FromSlash() when making your map keys, does that solve it for you in a more cross-platform way? I feel like that would be the most correct solution. (I could be wrong, but not sure yet.)