tracer.xml overridden error handling

Question

tracer.xml overridden error handling

ckho opened this issue 5 years ago · 13 comments

In our current Mule application, we did a validation of value. If that does not pass, we will catch the error and then return a pair of error code and payload we set.

However, after importing the "tracer.xml", the error is overridden and becomes a 500 error.

Expected behaviour:

Actual behaviour after importing "tracer.xml":

Answer 1 · 2020-02-18T04:58:26.000Z

Thanks for reporting it. What version are you using?

Answer 2 · 2020-02-18T04:59:51.000Z

Mule: 4.1.6
elastic-apm-mule4-agent: 0.0.3 (built from distributed-http-tracing branch)

Answer 3 · 2020-02-18T05:01:25.000Z

I built and tested it with 4.2.2, that branch is a bit of a dead-end where I experimented with few undocumented Mule APIs. Can you please test it with master?

Answer 4 · 2020-02-18T05:40:13.000Z

Justed tested again with master and 4.1.6. The error is still overridden.

Answer 5 · 2020-02-18T06:37:16.000Z

Can you try it on 4.2.2 please?

On Tue, 18 Feb 2020 at 4:40 pm, Chunkit Ho ***@***.***> wrote: Justed tested again with master and 4.1.6. The error is still overridden. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=ADXR5DPQM4NC6EKHTMQQOP3RDNYD5A5CNFSM4KWQLCVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMAU32Q#issuecomment-587288042>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADXR5DNKGSB4ZEB4HQQPIULRDNYD5ANCNFSM4KWQLCVA> .

-- Kind regards, Michael Hyatt m: +614 4880 1078

Answer 6 · 2020-02-18T06:42:36.000Z

Can you try it on 4.2.2 please?

Sorry I can't test it on 4.2.2, because my environment is limited by the PCE version. I can only use Mule runtime up to 4.1.x.

Is there any way to enable more log for debugging?

Answer 7 · 2020-02-18T07:16:18.000Z

I just find out something. The issue exists only when the error is handled in a flow reference.

Mule: 4.1.6
elastic-apm-mule4-agent: 0.0.2 (master)

The one that works well:

The one that doesn't work:

Answer 8 · 2020-02-18T07:51:28.000Z

One more finding:
All error handling in all flows except the ones listening to the HTTP requests are omitted.

I do an experiment with 3 flow:
Root flow: Listen to the http request. Call middle flow. Catch exception, create a variable "rootFlag" and return the value of all the flags.
Middle flow: Call lower flow. Catch exception and create a variable "middleFlag".
Lower flow: Do validation. Catch exception and create a variable "lowerFlag".

Only the error handling in root flow is executed.

Answer 9 · 2020-02-18T22:53:07.000Z

Yep, I saw some irregularities in how exceptions are handled. I will take a look. BTW, do you know if Mulesoft released anything after 4.1.6 and 4.2.2? Any news on 4.3?

…

On Tue, 18 Feb 2020 at 18:51, Chunkit Ho ***@***.***> wrote: One more finding: All error handling in all flows except the ones listening to the HTTP requests are omitted. I do an experiment with 3 flow: Root flow: Listen to the http request. Call middle flow. Catch exception, create a variable "rootFlag" and return the value of all the flags. Middle flow: Call lower flow. Catch exception and create a variable "middleFlag". Lower flow: Do validation. Catch exception and create a variable "lowerFlag". Only the error handling in root flow is executed. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=ADXR5DIDIRNLXAU2VYEW5M3RDOHQDA5CNFSM4KWQLCVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMA6IFQ#issuecomment-587326486>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADXR5DIH4ZCG42XC47KEGQLRDOHQDANCNFSM4KWQLCVA> .

Answer 10 · 2020-02-19T04:31:19.000Z

Not yet. Still 4.1.6 and 4.2.2. Seems like their release cycle is not that regular. But Elastic looks like very regular. Almost every 2 months they have a new version

…

On 19 Feb 2020, 6:53 AM +0800, Michael Hyatt ***@***.***>, wrote: Yep, I saw some irregularities in how exceptions are handled. I will take a look. BTW, do you know if Mulesoft released anything after 4.1.6 and 4.2.2? Any news on 4.3? On Tue, 18 Feb 2020 at 18:51, Chunkit Ho ***@***.***> wrote: > One more finding: > All error handling in all flows except the ones listening to the HTTP > requests are omitted. > > I do an experiment with 3 flow: > Root flow: Listen to the http request. Call middle flow. Catch exception, > create a variable "rootFlag" and return the value of all the flags. > Middle flow: Call lower flow. Catch exception and create a variable > "middleFlag". > Lower flow: Do validation. Catch exception and create a variable > "lowerFlag". > > Only the error handling in root flow is executed. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#4?email_source=notifications&email_token=ADXR5DIDIRNLXAU2VYEW5M3RDOHQDA5CNFSM4KWQLCVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMA6IFQ#issuecomment-587326486>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADXR5DIH4ZCG42XC47KEGQLRDOHQDANCNFSM4KWQLCVA> > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Answer 11 · 2020-03-11T09:53:50.000Z

I have drilled the code and done some experiment.

I found that if we add any hook, like exceptionally or thenApply, on action.proceed(), the issue would occur.

This is tested on a raw project without adding the apm-agent.
I created a Mule project and then overrided both the ProcessorInterceptorFactory and ProcessorInterceptor.

Answer 12 · 2020-03-11T22:34:14.000Z

Yes, agree, exception handling needs to be refined a bit further. I need to put together a quick design brief on how the exceptions should be handled within the APM agent: resuming the execution flow, capturing exception, etc.

Answer 13 · 2020-03-11T22:39:48.000Z

The main issue with the notification API in Mule 4 is that there is no way now to mutate the Mule event in the notification. In Mule 3 I was able to mutate the event to add properties to propagate the distributed header. In Mule 4 it is completely changed. I was also experimenting with the new APIs to find a way not to store a thread-safe map of in-flight transactions and spans, but it seems to be the only way so far. I was working on other things hoping MuleSoft will release 4.3 and finally update the documentation for the runtime APIs, but it hasn't happened yet.

…

On Wed, 11 Mar 2020 at 22:12, Chunkit Ho ***@***.***> wrote: I see that notification API is used in mule3-agent. It looks like the API is still available in Mule 4. Can the tracing be implemented using that? Was there any reason changed the implementation way? https://www.mulesoft.org/docs/site/4.1.1/apidocs/org/mule/runtime/api/notification/NotificationListener.html — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=ADXR5DPOF5XJ6S2OOUUW7DLRG5W23A5CNFSM4KWQLCVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOPD77Y#issuecomment-597573631>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADXR5DKQRNLV5QSQYLO25OLRG5W23ANCNFSM4KWQLCVA> .