microsoft/Cognitive-Face-Android

Usage in SDK > 22

Opened this issue · 0 comments

As I was developing a new Android app, I had tremendous problems using the library as is due to the mixing of SDK versions. When I tried to use the library as is (bumping my minSdkVersion down to 22) I not only had libraries that didn't work but the compiler complaining that Google Play wanted at least v26. If I tried to bump my minSdkVersion up to 24 or 26 of course the library would throw an exception on load. I have taken a copy of the code and compiled with the following:
android {
compileSdkVersion 26

defaultConfig {
    minSdkVersion 22
    targetSdkVersion 26
}
compileOptions {
    sourceCompatibility '1.8'
    targetCompatibility '1.8'
}

}
that seems to work with my app defined as:
compileSdkVersion 28
defaultConfig {
minSdkVersion 24
targetSdkVersion 28
versionCode 1
versionName "1.0"
}

Should I simply submit a PR? Are you taking them?