Bad contrast between `link` (and text) in message and `background` in `selected row`
jsoref opened this issue · 1 comments
Version info
Version: 1.83.1 (Universal)
Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc
Date: 2023-10-10T23:46:55.789Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.0.0
MS-SarifVSCode.sarif-viewer v3.4.2
Links in messages are blue, which is fine, but when the row containing them is selected, the link becomes virtually invisible:
Here's that same row selected, but inactive:
You can experience this by loading any sarif report that does this, probably the easiest thing is to pick any of the repositories in https://github.com/check-spelling-sandbox/ that have check-spelling active, the pictures above come from: https://github.com/check-spelling-sandbox/google-quiche/security/code-scanning?query=is:open+branch:spell-check-with-spelling
To test this, you can download check-spelling-sarif.json.zip from
https://github.com/check-spelling-sandbox/sarif-vscode-extension/actions/runs/6547640060
Note that when Microsoft would use a dark blue background for a highlighted row (in Windows), it would change the foreground color from black to white so that there would be enough contrast to read it:
