microsoft/sarif-vscode-extension

`No results found with provided filter criteria` doesn't make sense when there are no results

Opened this issue · 0 comments

jsoref commented
  1. Run a SARIF generating tool in github against a commit that doesn't yield any SARIF results (you should celebrate this)
  2. Select the LOCATIONS or RULES tabs:
    image

Note that it says:

No results found with provided filter criteria.
Clear Filters

Clearing Filters will not change the results because there are no results.

Instead, the message should just say that there were no results.

  • You could be cute about this (🥳), or
  • You could suggest that they might want to add other workflows to generate more results.