microsoft/sarif-vscode-extension

`Refresh results` button doesn't trigger update to tab title

Opened this issue · 0 comments

Type: Bug

  1. Open a git clone for a repository with sarif data -- I'm using https://github.com/check-spelling-sandbox/FCPCafe -- you could fork that and trigger a run for the spell-check-with-spelling branch (eventually the spell-check branch as at some point the former may have no results)
  2. when asked if you want to import sarif data, click the connect button
  3. push a commit to your repository and wait for the sarif generating workflow to run
  4. click Refresh results

Expected results

When the heading changes to Checking GitHub Advanced Security... and the tree view blanks out, the tab title should change to Refreshing or something

Actual results

The tab title changes to 0 SARIF Results -- this is incorrect, there are results, they just haven't been retrieved by the extension

refresh.results.mov

Version info

Extension version: 3.4.4
VS Code version: Code 1.95.1 (Universal) (65edc4939843c90c34d61f4ce11704f09d3e5cb6, 2024-10-31T05:14:54.222Z)
OS version: Darwin arm64 24.0.0
Modes:

System Info
Item Value
CPUs Apple M1 Max (10 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Load (avg) 2, 3, 3
Memory (System) 64.00GB (0.53GB free)
Process Argv --crash-reporter-id 1fc67ee2-0174-4598-9f98-4537df0dd32c
Screen Reader no
VM 0%
A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
vscrp:30673768
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
945dj816:31013170
dvdeprecation:31068756
dwnewjupytercf:31046870
newcmakeconfigv2:31071590
impr_priority:31102340
nativerepl2:31139839
refactort:31108082
pythonrstrctxt:31112756
cf971741:31144450
iacca1:31171482
notype1:31157159
5fd0e150:31155592
dwcopilot:31170013