Overlap matrix resulting in many -1.

[tonyngjichun]

In megadepth_utils/preprocess_scene.py line 209, the inner loop's scope is defined as for idx2 in range(idx1 + 1, n_images):.
This results in the lower triangle of the overlap matrix being all -1, hence drastically reducing the number of positive pairs. Could you confirm this is the case? Thanks

[mihaidusmanu]

Even though the for only loops over the upper triangle, the lower triangle is also filled - see lines 219-220 of the same file.

d2-net/megadepth_utils/preprocess_scene.py

Lines 219 to 220 in be09ec7

	overlap_matrix[idx1, idx2] = len(matches) / min_num_points3D
	overlap_matrix[idx2, idx1] = len(matches) / min_num_points3D

[tonyngjichun]

Hi,

didn't notice this, thanks! gonna close the issue.