Support Java Platform Module System (JPMS)

[wimdeblauwe]

I am doing some tests with the JPMS and I noticed that MigLayout does not seem to support it at present.

Some articles that might be of help to know what should be done:

• https://dzone.com/articles/java-platform-module-systemjpms-migration-guide-fo
• https://www.infoq.com/articles/Java-Jigsaw-Migration-Guide/

[wimdeblauwe]

It seems that adding this to my own module-info.java makes it possible to use MigLayout:

module myapplication {
    requires miglayout.core;
    requires miglayout.javafx;
}

[tbee]

These are automatic modules. But I've modularized JFXtras, so doing the same for MigLayout should not be a problem. But that means we need to support a Java 9+ version. Since Java 12 is out, that may be prudent by now. Maybe v6.x?

…

On 9-7-2019 14:55, Wim Deblauwe wrote: It seems that adding this to my own |module-info.java| makes it possible to use MigLayout: |module myapplication { requires miglayout.core; requires miglayout.javafx; } | — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#67?email_source=notifications&email_token=AAK5BQSDFZCGYXWQRZBLO4LP6SDEVA5CNFSM4H7FB5I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZQFREA#issuecomment-509630608>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAK5BQSHYCIHXWJWOOFNUILP6SDEVANCNFSM4H7FB5IQ>.

[wimdeblauwe]

The automatic modules are ok for me, but it would be good to document the names of the modules so people can know what to put in the requires directive for each miglayout module.

[mikaelgrev]

I'm all for making a v6 of MigLayout which would be modularized. I haven´t myself needed modules yet though so if @tbee could do it that would be great.

[tbee]

I've created a separate branch (jpms) and started adding the module-info files; swing and javafx seem to be ok, but I'm running into troubles for swt, the native jars are not being resolved.

[aalmiray]

I can setup a branch and apply the https://github.com/moditect/moditect plugin.
It may be the case that only core, swing, and javafx may be properly modularized (full modules) while the other JARs may use just the Automatic-Module-Name manifest entry to claim their respective com.miglayout.* module name instead of the auto generated name based on the JAR file name.